Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58357 )
Change subject: tests: Add tests to write on chip ......................................................................
Patch Set 2:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/58357/comment/a8513ccf_3c295039 PS2, Line 270: flash
`flashctx`, I was initially confused by all the flashes >_< lol.
yes three lines in a row start with "struct flash...." :)
I took this idea from spi_send_command and spi_send_multicommand declarations, they both use `const struct flashctx *flash` as first parameter, and then the same `const struct flashctx *flash` is repeated in every programmer.
Ok so let's compare visually, current version: struct flashrom_flashctx flash = { 0 }
proposed version: struct flashrom_flashctx flashctx = { 0 }
Another option is to go the programmer way and have struct flashctx flash = { 0 }
If we decide to change I wanted to ask, I would have it as separate patch because all 6 tests (4 existing and 2 new) are using the same pattern, all them need to change. Is it ok to have rename patch on the top of this?
I do apologise to my reviewers for having too many flashes in one comment! :))