Attention is currently required from: Nikolai Artemiev, Evan Benn.
Hello build bot (Jenkins), Angel Pons, Nikolai Artemiev,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68127
to look at the new patch set (#2).
Change subject: s25f.c: Fix undefined behaviour on shift ......................................................................
s25f.c: Fix undefined behaviour on shift
dev_id, a uint8_t, was shifted left by 24 bits. After promotion to int, this results in shifting into the sign bit, which is undefined behaviour. Cast to uint32_t to prevent the promotion to signed int.
BUG=None BRANCH=None TEST=None
Change-Id: I88188ef2ba2af919eeae9ba08916374d31d8b989 Signed-off-by: Evan Benn evanbenn@chromium.org --- M s25f.c 1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/27/68127/2