Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47005 )
Change subject: spi25.c: Use JEDEC consts in spi_simple_write_cmd() calls
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c
File spi25.c:
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c@524
PS2, Line 524: 0xdb
this one isn't standard, I guess?
https://review.coreboot.org/c/flashrom/+/47005/2/spi25.c@634
PS2, Line 634: return &spi_block_erase_dc;
I guess this could also be updated
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1876781672fe03302af4a6ff8d365f2e6c3b6f13
Gerrit-Change-Number: 47005
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Oct 2020 09:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment