Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41655 )
Change subject: tests/: Add helper.c unit tests
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/41655/1/tests/helpers.c
File tests/helpers.c:
https://review.coreboot.org/c/flashrom/+/41655/1/tests/helpers.c@52
PS1, Line 52: assert_int_equal(0x5A, reverse_byte(0x5A));
yes? byte is reversed.
Yes, I just dropped a (resolved) comment to remember why this is correct
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41655
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If4a1fe7c499f51bb9d7cd48ef26caf9dfae3c1fa
Gerrit-Change-Number: 41655
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 May 2020 16:19:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment