Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21830 )
Change subject: fixup! Convert flashrom to git ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/21830/1/Makefile File Makefile:
https://review.coreboot.org/#/c/21830/1/Makefile@a544 PS1, Line 544:
Why drop the empty line? anyway the whole block seems to be a dead
Dunno why I decided to put it in here TBH. And yes, the offline block will be gone anyway and then it looks fine (but someone told me to slice my changes up into a myriad of pieces ;). I will rearrange that to be included in the patch that removes the offline block when I add the sign-offs.
https://review.coreboot.org/#/c/21830/1/Makefile@529 PS1, Line 529: required by the build process when packaging flashrom
This is not true, AFAIU (the old text wasn't very accurate either).
Yep, that's better. Thanks.