Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61362 )
Change subject: util/ich_descriptors_tool: Invert the meaning of 'dual_output' bit ......................................................................
util/ich_descriptors_tool: Invert the meaning of 'dual_output' bit
In the Flash Component description register (FLCOMP) bit 30 reports the capability of using dual output for fast read operation on the flash component. According to the SPI Programming Guide the dual output is enabled when this bit is set and disabled if not (checked for Panther Point, Lewisburg C620, Apollo Lake and Elkhart Lake). Currently the logic displays it the other way around when parsing the descriptor.
This patch changes this so now if bit 30 in FLCOMP is not set, dual read support for fast read operation is shown as disabled.
Change-Id: If6282ac8326ab0b92e9c70c09dba0299bf0deb6f Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M ich_descriptors.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/61362/1
diff --git a/ich_descriptors.c b/ich_descriptors.c index 56a3c67..c54e819 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -365,7 +365,7 @@ pprint_freq(cs, desc->component.modes.freq_fastread)); if (cs > CHIPSET_6_SERIES_COUGAR_POINT) msg_pdbg2("Dual Output Fast Read Support: %sabled\n", - desc->component.modes.dual_output ? "dis" : "en"); + desc->component.modes.dual_output ? "en" : "dis");
int has_forbidden_opcode = 0; if (desc->component.FLILL != 0) {