22 Jan
2021
22 Jan
'21
10:14 a.m.
Attention is currently required from: Edward O'Callaghan. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37240 )
Change subject: cbtable.c: don't assume high addresses can fully map 1 MiB ......................................................................
Patch Set 4:
(2 comments)
File cbtable.c:
https://review.coreboot.org/c/flashrom/+/37240/comment/0b609d4b_5297f5f5 PS4, Line 248: mapping_size += getpagesize() - It looks like this shouldn't need to wrap.
https://review.coreboot.org/c/flashrom/+/37240/comment/07bb6caa_134f5f58 PS4, Line 251: base = physmap_ro("high tables", start_addr, Here too.
--
To view, visit https://review.coreboot.org/c/flashrom/+/37240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43705c19dd7c816098d03f528bde6f180c4c8f24
Gerrit-Change-Number: 37240
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Fri, 22 Jan 2021 09:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment