Attention is currently required from: Sam McNally, Stefan Reinauer, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Nikolai Artemiev.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52425 )
Change subject: Revert "Makefile: Explicitly set '-std=c99'"
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I agree. […]
The bottom is not very deep, afaics. I've basically seen two things:
* The absence of an `asm` statement with c99. Because it's not a reserved keyword, the compiler has to allow it as an identifier and can't define it itself.
* On some hosts some combinations of feature test macros don't work. We could blame libc developers for that. We could try to patch bad libc implementations and upstream everything. But if we want it to compile for the random person who seeks help on IRC, I don't see how we can do better than adapting to odd environments.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I57b5125207de3fd156dface67cba605da893d6aa
Gerrit-Change-Number: 52425
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 22 Apr 2021 11:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment