Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36432 )
Change subject: sb600spi.c: Remove 'amd_gen' out of global state. ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/flashrom/+/36432/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/36432/1//COMMIT_MSG@7 PS1, Line 7: . no trailing period please
https://review.coreboot.org/c/flashrom/+/36432/1//COMMIT_MSG@10 PS1, Line 10: . Thus , thus
https://review.coreboot.org/c/flashrom/+/36432/1/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36432/1/sb600spi.c@110 PS1, Line 110: int update?
Also change the `return -1`
https://review.coreboot.org/c/flashrom/+/36432/1/sb600spi.c@594 PS1, Line 594: amd_gen Instead, check if it's not `_UNKNOWN`?