Attention is currently required from: Nico Huber, Angel Pons, Nikolai Artemiev.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62733 )
Change subject: writeprotect_ranges.c: Check for underflow when using unsigned types
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
Heh, a third solution comes to mind. Sorry if this is getting too […]
Yes, I think your reasoning is accurate. I was also thinking along the same lines earlier. Also, these cases are perfectly possible, and asserting bits->bp_bit_count>1 would stop the program inappropriately. It would be best to just ignore the tool for this issue.
Also, ignore my previous patch set. :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62733
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2766ef8e34f7121dad746e5f32a835d480ae1cad
Gerrit-Change-Number: 62733
Gerrit-PatchSet: 5
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 18:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment