Attention is currently required from: Sam McNally.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37240 )
Change subject: cbtable.c: don't assume high addresses can fully map 1 MiB
......................................................................
Patch Set 5:
(2 comments)
File cbtable.c:
https://review.coreboot.org/c/flashrom/+/37240/comment/f2cc954e_c9dae50f
PS4, Line 248: mapping_size += getpagesize() -
It looks like this shouldn't need to wrap.
Done
https://review.coreboot.org/c/flashrom/+/37240/comment/52bc468f_023b8a6d
PS4, Line 251: base = physmap_ro("high tables", start_addr,
Here too.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/37240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43705c19dd7c816098d03f528bde6f180c4c8f24
Gerrit-Change-Number: 37240
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 01:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment