9 Sep
2020
9 Sep
'20
3:43 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/44621/5/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/5/ich_descriptors.c@945 PS5, Line 945: // content->ICCRIBA > 0x34 I don't think this comment adds any value
--
To view, visit https://review.coreboot.org/c/flashrom/+/44621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669
Gerrit-Change-Number: 44621
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou bryant.ou.q@gmail.com
Gerrit-Reviewer: David Hendricks dhendrix.sync@gmail.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 15:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment