4 Mar
2019
4 Mar
'19
2:41 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31068 )
Change subject: Fix erasing of unaligned regions ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3:
How about risking it on master and guarding on the 1.0.x cherry-pick?
I tried to find some source to support that recollection but I can't, so for what it's worth, feel free to do it.
At the point where these free()s happen (and a crash would occur), everything crucial has been done anyway.
--
To view, visit https://review.coreboot.org/c/flashrom/+/31068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5fc35310f0b090f218cd1d660e27fb39dd05c3c5
Gerrit-Change-Number: 31068
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:41:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment