16 May
2023
16 May
'23
5:48 p.m.
Attention is currently required from: Miklós Márton, Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75234 )
Change subject: Makefile: Simplify the NI-845X detection ......................................................................
Patch Set 2:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/75234/comment/4f8f45e5_8ebe4ea3 PS2, Line 217: DIR
Well the actual problematic line was in this one: […]
Oh, right, there's `$(...)` around the variable name missing in the `if`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2115c30d0884e35eb549a31beef04d966ba4f491
Gerrit-Change-Number: 75234
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Tue, 16 May 2023 17:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-MessageType: comment