Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Hsuan-ting Chen, Subrata Banik.
Sam McNally has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/flashrom/+/83144?usp=email )
Change subject: ichspi: Add support for Panther Lake
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83144/comment/801e16b6_60e842a9?usp... :
PS1, Line 20: -
Did a `p` in `-p` here get dropped?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/83144/comment/2fdaf846_80c10530?usp... :
PS1, Line 518: cs == CHIPSET_PANTHER_LAKE) {
```suggestion
cs == CHIPSET_PANTHER_LAKE) {
```
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83144?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I99cd8eb7cbb11381f8e8455b06cf90b9db77d8f0
Gerrit-Change-Number: 83144
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 21 Jun 2024 01:15:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes