Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build ......................................................................
Makefile: Remove a bashism when searching for sphinx-build
e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes.
Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2 Signed-off-by: Bart De Schuymer bdschuym@artinalgorithms.be Reviewed-on: https://review.coreboot.org/c/flashrom/+/77288 Reviewed-by: Peter Marheine pmarheine@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi patrick@coreboot.org Reviewed-by: Jan Samek jan.samek@siemens.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Patrick Georgi: Looks good to me, approved build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved Jan Samek: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile index bc3eecb..bf01d0f 100644 --- a/Makefile +++ b/Makefile @@ -250,7 +250,7 @@ HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c) HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c) HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes)) -HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no) +HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) >/dev/null 2>/dev/null && echo yes || echo no) EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe))
override CFLAGS += -Iinclude