12 Apr
2022
12 Apr
'22
12:22 p.m.
Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31016 )
Change subject: hwaccess: add endianness converting deserialization functions ......................................................................
Patch Set 19:
(1 comment)
File platform/memaccess.c:
https://review.coreboot.org/c/flashrom/+/31016/comment/8ac621a9_7352ec83 PS19, Line 26: base + offset
Technically this is wrong because arithmetic is undefined for […]
can we just use uintptr_t as type instead of void*? read_le8(uintptr_t base, size_t offset)?
--
To view, visit https://review.coreboot.org/c/flashrom/+/31016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452
Gerrit-Change-Number: 31016
Gerrit-PatchSet: 19
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 12 Apr 2022 10:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment