Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83795?usp=email )
Change subject: flashchips: add GD25LB512ME
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
completed
Commit Message:
https://review.coreboot.org/c/flashrom/+/83795/comment/30e45e63_3c0d7707?usp... :
PS1, Line 7: flashchip
Oh I missed one more thing: this should be `flashchips:` prefix, it's referring to the name of array […]
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83795/comment/fc24d17d_cc51af81?usp... :
PS1, Line 7074: GIGADEVICE_GD25LR512ME
You need to add a comment in `include/flashchips. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83795?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I04103814f901478098c1a989f4239792b64073ec
Gerrit-Change-Number: 83795
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim
vlim@gigadevice.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 10 Aug 2024 18:14:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
