Attention is currently required from: Nico Huber, Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59280 )
Change subject: pcidev: Move pci_dev_find() from internal to canonical place
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Well the rename was separated out as I suspected someone would want it separate, I would actually pr […]
Ack, for the second part. I haven't noticed the comment. The last time I looked at programmer.h was for CB:62834.
The renaming in a separate commit was due to the fact, that you haven't mention the renaming in the previous commit.
When updating the commit message I'm fine with squashing. What do you think of these commit message?
pcidev: Move pci_dev_find() from internal.c to shared pcidev.c, rename it to pcidev_find() for alignment with the functions of the file.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie21f87699481a84398ca4450b3f03548f0528191
Gerrit-Change-Number: 59280
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 09:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment
