Attention is currently required from: Anastasia Klimchuk, Miklós Márton.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email )
Change subject: ni845x_spi: pass global state through func params
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS2:
Just a small note from me: maybe we can do the code review first (for all the patches in the chain) […]
Thanks to the now available build instructions for NI-845x on Windows. I was able to compile this chain of patches and can confirm that it doesn't throw any errors.
But the testing on real hardware is still required ;)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72154/comment/35604589_c1f0da32 :
PS2, Line 233: set_io_voltage_mV
I see, that's a good finding! […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72154?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61
Gerrit-Change-Number: 72154
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 14 Jul 2023 23:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment