Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72657 )
Change subject: meson make: use VERSION file
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/72657/comment/8d860e24_b2177a0b
PS6, Line 19: flashrom 1.4.0-devel (git:v1.2-1172-g7f186838)
It is a bit odd to have 1.4.0 and at the same time v1. […]
The problem is that since 1.2, we have no tags on the master branch. From the moment of the first 1.4 rc this looks like ``1.4.0-rc1 (git:v1.4.0-rc1-2-g7f186838)``
I just started with 1.4.0-devel to get some entry here since we are working on 1.4 and are not on the 1.3 branch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idc17eadb397b3c579bddfbf9ae6bf1b171f5dfb7
Gerrit-Change-Number: 72657
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Sat, 06 May 2023 10:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment
