Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56469 )
Change subject: programmer_table: Remove space between address operator and variable
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File programmer_table.c:
https://review.coreboot.org/c/flashrom/+/56469/comment/ab7282c7_460b3e64
PS1, Line 176: const size_t programmer_table_size = ARRAY_SIZE(programmer_table);
I was told to avoid new lines at the end. But don't know if there are fixed style guidelines.
coreboot has a lint check for this. My editor automatically adds the newline.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308
Gerrit-Change-Number: 56469
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 21 Jul 2021 09:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment