Nico Huber has posted comments on this change. ( https://review.coreboot.org/18925 )
Change subject: chipset_enable: Add support for Intel Skylake ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/18925/2/chipset_enable.c File chipset_enable.c:
PS2, Line 869:
The parameter is unused in ich_init_spi(). I will just remove it.
Done
PS2, Line 869:
We do anyways, despite the if constructs below. We do anyways, despite the if constructs below.
Right. I was obviously in doubt how to implement it. Now that the parameter is gone, it's also clear that we don't have to keep the `struct pci_access`.
Line 870: else
Do we really need a goto here?
Done