Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46623 )
Change subject: realtek_mst_i2c_spi.c: Introduce ISP enter param ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c@514 PS1, Line 514: if (enter_isp) {
Seems a little out of scope for this change but Shiyu would need to ask RTK that. […]
It would be nice to automatically detect whether entering ISP mode is necessary. That way, there's one less option to potentially be wrong on! 😄
But I agree, this can be done in a separate patch.