Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38488 )
Change subject: Automatic programmer driver writer ......................................................................
Patch Set 3:
(4 comments)
AFAICS all comments have now been addressed.
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@16 PS1, Line 16: for a in *; do test -f $a.mine && mv $a.mine $a; done
No, that would also mess with files which you already changed manually. […]
Done
https://review.coreboot.org/c/flashrom/+/38488/1//COMMIT_MSG@28 PS1, Line 28: Icdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcdcd000001
Indeed, the Change-Id is freely selectable subject to some length and character set constraints. […]
Done
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh File build_new_driver.sh:
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@1 PS1, Line 1: #!/bin/bash
Will be fixed in the next iteration.
Done
https://review.coreboot.org/c/flashrom/+/38488/1/build_new_driver.sh@42 PS1, Line 42:
Done.
Done