8 Oct
2021
8 Oct
'21
6:54 p.m.
Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431 )
Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2: Looks good beside two cosmetic issues.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/40431/comment/32189cfc_0c120a51 PS2, Line 7444: 1024B Datasheet says 256B?
https://review.coreboot.org/c/flashrom/+/40431/comment/2a40338a_e9ffac00 PS2, Line 7467: }, Missing
.printlock = spi_prettyprint_status_register_bp3_srwd,
--
To view, visit https://review.coreboot.org/c/flashrom/+/40431
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494
Gerrit-Change-Number: 40431
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Oct 2021 16:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment