Attention is currently required from: Vadim Bendebury, Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 )
Change subject: Add W25Q512NW-IM ID to flashrom
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64405/comment/ae49665f_221079dd
PS2, Line 23: Signed-off-by
move this line to after the Change-Id: line.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/64405/comment/ebfb6616_835163cf
PS1, Line 17973: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ,
Done
Thanks Angel! Please mention the 4BA corrections in the commit message too, maybe with Spotted-by: Angel ?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9debeda01d77444a5ebe9808ff80a337f320ef65
Gerrit-Change-Number: 64405
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 23 May 2022 00:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment
