Nico Huber has posted comments on this change. ( https://review.coreboot.org/17946 )
Change subject: Add a convenient libflashrom interface ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/17946/6/flashrom.c File flashrom.c:
Line 2507: return 1;
Would it make sense to add a wrapper function that calls unmap_flash() and
Done
It only contains unmap_flash() for now, since this was also the only cleanup done before.
PS6, Line 2610: : }
"containing" might be a better word for this
Done
Line 2696: }
Style nit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g
Done
https://review.coreboot.org/#/c/17946/6/libflashrom.c File libflashrom.c:
PS6, Line 42: fl_
I had originally thought fl_ was used when describing flash layout stuff th
I used it for the library interface originally. `struct fl_layout` is part of it. I can't remember why I used it for the layout internal parts too. I dropped the fl_ prefix from the layout parts beside `struct fl_layout` for now. At least until we have an official prefix for the library.
Line 301: return 1;
How about adding:
Done