26 Dec
2020
26 Dec
'20
12:59 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1:
Patch Set 1:
Thanks for the review! I've never submitted code here and it tells me I don't have permission, what am I missing? 😄
Only developers can submit patches, even after they've been approved. It's too easy to submit a patch train out-of-order by accident and break building the master branch until someone issues a fix. With great power comes great responsibility :D
--
To view, visit https://review.coreboot.org/c/flashrom/+/48880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If17a3d58c02222f61b4e0335879eeed1638b583c
Gerrit-Change-Number: 48880
Gerrit-PatchSet: 1
Gerrit-Owner: Miriam Polzer mpolzer@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan edward.ocallaghan@koparo.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Dec 2020 12:59:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment