Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49107 )
Change subject: tree/: Drop const from opaque data ptr in master definitions
......................................................................
Patch Set 2:
An alternative solution is also provided here https://review.coreboot.org/c/flashrom/+/49131 to keep the bitbang_spi_master struct instances const by wrapping them. Although I am not sure this necessarily yields anything beyond looking nicer.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6844cd0c3666c0a1b8c5f738e8d6b957e56d1b0
Gerrit-Change-Number: 49107
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 03:43:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment