[flashrom-gerrit] Change in flashrom[master]: programmer: Add Developerbox/CP2104 bit bang driver

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/26948 )

Change subject: programmer: Add Developerbox/CP2104 bit bang driver
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/26948/2/developerbox_spi.c
File developerbox_spi.c:

https://review.coreboot.org/#/c/26948/2/developerbox_spi.c@71
PS2, Line 71: ()
Style remark (nitpick): add 'void'

https://review.coreboot.org/#/c/26948/2/developerbox_spi.c@203
PS2, Line 203: int developerbox_spi_init()
void

https://review.coreboot.org/#/c/26948/2/programmer.h
File programmer.h:

https://review.coreboot.org/#/c/26948/2/programmer.h@77
PS2, Line 77: 	PROGRAMMER_DEVELOPERBOX,
This I think should read *_DEVELOPERBOX_SPI, since the driver file is called developerbox_spi.c