[flashrom-gerrit] [M] Change in flashrom[master]: ni845x_spi: pass global state through func params

[Miklós Márton (Code Review)]

Attention is currently required from: Alexander Goncharov.

Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154 )

Change subject: ni845x_spi: pass global state through func params
......................................................................

Patch Set 5:

(1 comment)

File ni845x_spi.c:

https://review.coreboot.org/c/flashrom/+/72154/comment/a944b7f7_22f0ffdd 
PS5, Line 131: static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, enum USB845x_type device_pid)
The compilation fails with:

declaration of 'device_pid' shadows a global declaration [-Werror=shadow]

I would vote for renaming the parameter to simply pid.