Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Steve Markgraf has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71801 )
Change subject: programmer: Add bitbanging programmer driver for Linux libgpiod ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71801/comment/08621013_36bc19f8 PS4, Line 9: old smartphone
This is cool! :)
Yes, I had to dump a 1.8V flash chip and recycled an old Samsung Galaxy A3 for that purpose by installing postmarketOS and running a few wires: https://steve-m.de/pictures/galaxy_a3_flashrom.jpg
https://review.coreboot.org/c/flashrom/+/71801/comment/88e12bf9_2c095ea0 PS4, Line 17: All arguments are required.
I think this can be mentioned in the manpage too.
Done
https://review.coreboot.org/c/flashrom/+/71801/comment/a47d82b4_b289074f PS4, Line 19: Reading of a 2048 kB flash chip on a Qualcomm MSM8916 SoC @800 MHz:
I suggest a little re-phrase of this, just to make clear what was the testing scenario that you ran. […]
Done
Patchset:
PS3:
You are right that we have two build systems [still], and those are make and meson. […]
Okay, added it to the test_build script, ran it successfully (after fixing a missing depdendency in the Makefile, programmer was missing in DEPENDS_ON_BITBANG_SPI).
I also added the package to all the Dockerfiles.
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/71801/comment/1d8b1bee_f811ae1d PS4, Line 137: LINUX GPIOD
We keep this in abc order, so you need to swap with previous entry (LINUX MTD).
Done
File README:
https://review.coreboot.org/c/flashrom/+/71801/comment/e945e1b2_6dbe9778 PS4, Line 76: libgpiod-dev (if you want support for Linux GPIO devices)
Could you please add this info to meson doc too? Here: […]
Done