Attention is currently required from: Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67886 )
Change subject: jlink_spi.c: Move variable `speed` into parameter struct
......................................................................
Patch Set 3:
(1 comment)
File jlink_spi.c:
https://review.coreboot.org/c/flashrom/+/67886/comment/d4c04cf2_fafeb2d5
PS3, Line 196: struct jlink_spi_parameters {
What's the point of this struct? Will it ever be used outside of the `jlink_spi_init()` function?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7af29e4bd107bfcda929155bbe603798d092fa79
Gerrit-Change-Number: 67886
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Tue, 27 Sep 2022 14:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment