Attention is currently required from: Anastasia Klimchuk, Miklós Márton.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160?usp=email )
Change subject: ni845x_spi: refactor singleton states into reentrant pattern ......................................................................
Patch Set 4:
(5 comments)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72160/comment/fc503d6d_4cca0e3e : PS3, Line 432: const struct ni845x_spi_data *data = flash->mst->spi.data;
I think data shall not be const here. See comments below.
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/7c683915_2979443d : PS3, Line 456: &io_voltage_in_mV,
The io_voltage_in_mV is not defined anymore. […]
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/63708814_cb1f4b41 : PS3, Line 481: &io_voltage_in_mV,
Same as in line 456
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/2ce447bd_3de0209a : PS3, Line 566: unsigned char CS_number;
The CS_number shall be initialized with 0, io_voltage_in_mV could be removed.
Done
https://review.coreboot.org/c/flashrom/+/72160/comment/7add950a_7193b240 : PS3, Line 635: data->io_voltage_in_mV = io_voltage_in_mV;
data->io_voltage_in_mV = requested_io_voltage_mV; […]
I've just dropped this line, because `io_voltage_in_mV` will be set in the `usb8452_spi_set_io_voltage()`