8 Jan
2018
8 Jan
'18
4:27 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23157 )
Change subject: board_enable: Wyse Cx0 thin client is not a laptop ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/23157/2/board_enable.c File board_enable.c:
https://review.coreboot.org/#/c/23157/2/board_enable.c@2474 PS2, Line 2474: 0x1106, 0x0409, 0x6334, 0x0920, 0x1106, 0x3119, 0x1106, 0x0110, "^C CLASS$" How confident are you that this combination isn't found in other devices? Especially the "C CLASS" string makes me wonder, is it a place holder that somebody forgot to fill? or related to "Cx0"?
--
To view, visit https://review.coreboot.org/23157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc9d48c61680f2dc6818b4dc7e1e721a97f0c0bb
Gerrit-Change-Number: 23157
Gerrit-PatchSet: 2
Gerrit-Owner: Lubomir Rintel lkundrak@v3.sk
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Jan 2018 16:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No