Attention is currently required from: Brian Norris, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
Change subject: flashrom: Don't throw around "delay 1 second" so lightly ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/80807/comment/67aff59d_47e80b61 : PS2, Line 13: https://review.coreboot.org/plugins/gitiles/flashrom/+/8ab49e72af8465d4527de... Oh, gitiles is down at the moment, maybe you can tell the file and line? I would have a look! :)
Patchset:
PS1:
alright, I dropped the "RFC" tag 😊
I have a question, Nikolai you said `we can add a quirk flag for them` , do you mean some existing flag or new one?
I agree the delay here looks too high level. Do you know which specific chip may, in theory, need this? Is it only for old chips? Maybe this can be a command-line flag, if it's really rarely needed.