Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48196 )
Change subject: Simplifying the initialisation flow for it85spi ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/48196/3/it85spi.c File it85spi.c:
https://review.coreboot.org/c/flashrom/+/48196/3/it85spi.c@310 PS3, Line 310: } ``` } else msg_pdbg("Registering IT85 SPI.\n"); ```
https://review.coreboot.org/c/flashrom/+/48196/3/it85spi.c@342 PS3, Line 342: ce_high = (unsigned char *)(base + 0xE00); /* 0xFFFFFE00 */ : ce_low = (unsigned char *)(base + 0xD00); /* 0xFFFFFD00 */ looks like you can just fold these into the below initialisation. ``` data->ce_high = (unsigned char *)(base + 0xE00); /* 0xFFFFFE00 */ data->ce_low = (unsigned char *)(base + 0xD00); /* 0xFFFFFD00 */ ```
https://review.coreboot.org/c/flashrom/+/48196/3/it85spi.c@362 PS3, Line 362: msg_pdbg("Registering IT85 SPI.\n"); remove