Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68249 )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: flashrom.c: Use programmer_init() func params over global ......................................................................
flashrom.c: Use programmer_init() func params over global
The 'programmer' intended to be used in the control flow of 'programmer_init()' is a parameter to the function. Therefore use that symbol directly over the global copy of it.
Change-Id: I71e61f0633bac2fc472971249910bf3bf57cd0eb Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/68249 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M flashrom.c 1 file changed, 19 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/flashrom.c b/flashrom.c index 3575822..6dae5e3 100644 --- a/flashrom.c +++ b/flashrom.c @@ -161,8 +161,8 @@ cfg.params = NULL; }
- msg_pdbg("Initializing %s programmer\n", programmer->name); - ret = programmer->init(&cfg); + msg_pdbg("Initializing %s programmer\n", prog->name); + ret = prog->init(&cfg); if (cfg.params && strlen(cfg.params)) { if (ret != 0) { /* It is quite possible that any unhandled programmer parameter would have been valid,