Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68434 )
Change subject: tree/: Replace NULL-case of programmer_delay() with internal_delay
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/68434/comment/1e04dc4f_bcbb9e79
PS1, Line 282: else
ok but that is outside this diff.
Yes outside this diff... I think I got confused because the body of `programmer_delay` has been changed recently, and this comment should have been in some of the earlier patches.
Probably it's more accurate to say: it's outside of this one patch, but belongs to the ongoing effort to un-globalize programmer delay.
I am fine to have it in a separate patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1da230804d5e8f47a6e281feb66f381514dc6861
Gerrit-Change-Number: 68434
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Tue, 01 Nov 2022 04:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment