Attention is currently required from: Thomas Heijligen, Peter Marheine.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75125 )
Change subject: README: Add installing and packaging instructions for meson
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
I would rather remove the build and packaging instructions from the readme, link only to the documen […]
That's a great idea!
Patchset:
PS2:
Thanks so much, I did both.
File README.rst:
https://review.coreboot.org/c/flashrom/+/75125/comment/41779ecc_362f4c8e
PS1, Line 171: meson install -C <your_build_dir>
There's already a copy of this in building_from_source.rst: which one should we keep? […]
And this is a great idea!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75125
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d5900538d54c43efcc8c5b7010df5d867f3b190
Gerrit-Change-Number: 75125
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Tue, 16 May 2023 12:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment
