25 Sep
2020
25 Sep
'20
5:20 a.m.
Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45674 )
Change subject: realtek_mst_i2c_spi.c: Introduce MCU reset param ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/flashrom/+/45674/4/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/45674/4/realtek_mst_i2c_spi.c@438 PS4, Line 438: if (reset_str && reset_str[0] == '1')
yes, we should. Waiting on Shiyu for feedback on where he wants this to go.
Updated the code and verified that the reset logic works now.
--
To view, visit https://review.coreboot.org/c/flashrom/+/45674
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib70bf7399e7541f30b6905cdb950a6fb7b74ae18
Gerrit-Change-Number: 45674
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Sep 2020 05:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally sammc@google.com
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment