Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40901 )
Change subject: lspcon_i2c_spi.c: Use '__func__' in error messages of just 'Error:'
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40901/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/40901/5//COMMIT_MSG@7
PS5, Line 7: Use '__func__' in error messages of just 'Error:'
Again, can you rephrase this to something that makes more sense?
Both Angel and I gave alternatives.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If3205d8e453cfcd37f725b4fd135fe1221c913c0
Gerrit-Change-Number: 40901
Gerrit-PatchSet: 5
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Apr 2020 08:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment