Attention is currently required from: Anastasia Klimchuk.
Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/84982?usp=email )
Change subject: Extract usbdev declarations to a separate header. ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS2:
Antonio, thank you for your contributions! I only have comments about commit message. […]
Done! Thank you very much!
Commit Message:
https://review.coreboot.org/c/flashrom/+/84982/comment/e90abbab_b27482d4?usp... : PS2, Line 7: Split
I would say "Extract" instead of Split.
Done
https://review.coreboot.org/c/flashrom/+/84982/comment/fddaaab9_03e0e4d9?usp... : PS2, Line 9: This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project. : Currently, most of the declarations reside in programmer.h making it difficult to really understand file dependency.
We have a max width for commit message text 72 chars https://flashrom. […]
Done