29 Oct
2019
29 Oct
'19
8:20 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36420 )
Change subject: sb600spi.c: Consolidate smbus dev reversion derivation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/36420/1/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36420/1/sb600spi.c@83 PS1, Line 83: find_smbus_dev
call it smbus_rev?
find_smbus_dev_rev() ?
--
To view, visit https://review.coreboot.org/c/flashrom/+/36420
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I766b29cc1c7d01aa0bcf6cb9ff5ab73fa1995dcd
Gerrit-Change-Number: 36420
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 29 Oct 2019 08:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment