[flashrom-gerrit] Change in flashrom[master]: Revert "Add support for Intel Emmitsburg PCH"

[David Hendricks (Code Review)]

Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, David Hendricks, Christian Walter, Stefan Reinauer, Deomid "rojer" Ryabkov, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )

Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:
> I think there is a bit of cross talking here.

Indeed, thanks for cutting through it :-)
> Let's just let the revert go though please, please remember commits are just hashes and are free we don't need to fight over this and we can re-land this once you addressed all the comments in a follow up patch that fixes the concerns.

Sure, I've created a follow-up that should address the concerns, incorporating various feedback from this and other patches. LMK what you think.
> Sorry all for the double post, one thing that I forgot to mention. Is there room here to perhaps write a unit-test as well as `guess_ich_chipset()` seems to be a pure function without side-effects?

Seems tedious but doable. AFAICT we'll basically give it one set of constants (ISLs, etc) and expect corresponding constants (CHIPSET_*) as outputs. Is that really valuable, or am I thinking of it incorrectly? Do we have an example that tests a similar function?