Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41080 )
Change subject: realtek_mst_i2c_spi.c: Fix _spi_write256() as documented
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/41080/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/41080/3//COMMIT_MSG@11
PS3, Line 11: documention
documentation
Done
https://review.coreboot.org/c/flashrom/+/41080/3/realtek_mst_i2c_spi.c
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/41080/3/realtek_mst_i2c_spi.c@36
PS3, Line 36:
One space as above?
Done
https://review.coreboot.org/c/flashrom/+/41080/3/realtek_mst_i2c_spi.c@387
PS3, Line 387: }
Above you do not add {} around the one line branch.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If61ff95697f886d3301a907b76283322c39ef5c7
Gerrit-Change-Number: 41080
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward Hill
ecgh@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 May 2020 11:10:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment