Attention is currently required from: Thomas Heijligen, Vasily Galkin, roman.stingler@gmail.com.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email )
Change subject: flashchips.c: Add support for IS25WQ040 ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: Vasily, I am so sorry your patch got lost and is waiting for so long! I hope you are still here. I have two small comments, and that should be it.
Also, if you could rebase your patch that would be great. It is currently in "merge conflict" state because other stuff has been merged meanwhile. Thank you!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58179/comment/5036ccc3_a339dee2 : PS5, Line 7792: 1024B Page 47 says OTP is 256Bytes ? Also are you sure about read and write?
https://review.coreboot.org/c/flashrom/+/58179/comment/f654f473_8d74b449 : PS5, Line 7793: /* QPI enable 0x35, disable 0xF5 */ QPI is not in the datasheet?