Attention is currently required from: Miklós Márton.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72154?usp=email )
Change subject: ni845x_spi: pass global state through func params
......................................................................
Patch Set 6:
(1 comment)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/72154/comment/32fab993_fbe14304 :
PS5, Line 131: static int32 ni845x_spi_open_resource(char *resource_handle, uInt32 *opened_handle, enum USB845x_type device_pid)
The compilation fails with: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72154?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5daeb0839a4cc18b82d38cc06eeba88a619bec61
Gerrit-Change-Number: 72154
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Tue, 30 May 2023 11:16:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-MessageType: comment