Attention is currently required from: Martin Roth, David Hendricks, Mario Limonciello, Daniel Campello. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51552 )
Change subject: meson: add missing meson options from ebuild ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51552/comment/ddedd4b2_06658845 PS2, Line 7: meson: add missing meson options from ebuild : : This change adds missing meson options from chromiumos-overlay flashrom : ebuild in order to migrate to meson. This commit message is more describing the motivations for it than specifically the change at hand.
Can I suggest you split into two patches with commit messages to something like:
``` meson: Add print_wiki option
Align meson options to be equivalent to the Makefile as they are used in Gentoo's ebuilds. ```
&&
``` meson: Generalise libFlashrom product to link as static or dyn
Allow the user to specify if they would like a static archive or a DSO produced for libFlashrom by way of the flag e.g., `-Ddefault_library=static`. ```